[
https://issues.apache.org/jira/browse/SCB-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404810#comment-16404810
]
ASF GitHub Bot commented on SCB-416:
------------------------------------
weichao666 commented on a change in pull request #613: [SCB-416]For load
balance rule configurations, we need provider service level configuration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/613#discussion_r175435231
##########
File path:
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/Configuration.java
##########
@@ -113,10 +114,11 @@ public int getSessionTimeoutInSeconds() {
}
}
- public int getSuccessiveFailedTimes() {
+ public int getSuccessiveFailedTimes(String microservice) {
final int defaultValue = 5;
// do not support MicroService level now
Review comment:
this annotation can be deleted too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> For load balance rule configurations, we need provider service level
> configuration
> ----------------------------------------------------------------------------------
>
> Key: SCB-416
> URL: https://issues.apache.org/jira/browse/SCB-416
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> Description:
> Now we can configure service level value to load balancer, e.g.
> cse.loadbalance.[serviceName].policy
> But we can not configure for Rule, e.g.
>
> cse.loadbalance.SessionStickinessRule.sessionTimeoutInSeconds
>
> we need to enable configurations like:
> cse.loadbalance.[serviceName].SessionStickinessRule.sessionTimeoutInSeconds
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
