[
https://issues.apache.org/jira/browse/SCB-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408845#comment-16408845
]
ASF GitHub Bot commented on SCB-416:
------------------------------------
wujimin commented on a change in pull request #613: [SCB-416]For load balance
rule configurations, we need provider service level configuration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/613#discussion_r176282128
##########
File path:
handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalancer.java
##########
@@ -146,4 +148,41 @@ public void testGetAllServers() {
Mockito.when(filter.getFilteredListOfServers(servers)).thenReturn(servers);
Assert.assertEquals(servers, loadBalancer.getAllServers());
}
+
+ @Test
+ public void testLoadBalanceWithSessionSticknessRule() {
+ SessionStickinessRule rule = new SessionStickinessRule();
+ LoadBalancer lb = new LoadBalancer("lb1", rule, "service");
+ Assert.assertEquals(lb.getMicroServiceName(), "service");
+ Assert.assertEquals("service", Deencapsulation.getField(rule,
"microserviceName"));
+
+ List<Server> servers = new ArrayList<>();
+ Server server = new Server("host1", 80);
+ server.setAlive(true);
+ Server server2 = new Server("host2", 80);
+ server2.setAlive(true);
+ servers.add(server);
+ servers.add(server2);
+ lb.setServerList(servers);
+
+ Server s = lb.chooseServer("test");
+ Assert.assertEquals(server2, s);
+ s = lb.chooseServer("test");
+ Assert.assertEquals(server2, s);
+
+ long time = Deencapsulation.getField(rule, "lastAccessedTime");
+ Deencapsulation.setField(rule, "lastAccessedTime", time - 1000 * 10);
+
Utils.updateProperty("cse.loadbalance.service.SessionStickinessRule.sessionTimeoutInSeconds",
9);
Review comment:
is it possible to use:
org.apache.servicecomb.foundation.test.scaffolding.config.ArchaiusUtils.setProperty(String,
Object)
if can not use it, is it possible to add a new method in it.
so that we can reuse the capability in other test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> For load balance rule configurations, we need provider service level
> configuration
> ----------------------------------------------------------------------------------
>
> Key: SCB-416
> URL: https://issues.apache.org/jira/browse/SCB-416
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> Description:
> Now we can configure service level value to load balancer, e.g.
> cse.loadbalance.[serviceName].policy
> But we can not configure for Rule, e.g.
>
> cse.loadbalance.SessionStickinessRule.sessionTimeoutInSeconds
>
> we need to enable configurations like:
> cse.loadbalance.[serviceName].SessionStickinessRule.sessionTimeoutInSeconds
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
