[
https://issues.apache.org/jira/browse/SCB-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442653#comment-16442653
]
ASF GitHub Bot commented on SCB-505:
------------------------------------
zhfeng opened a new pull request #175: SCB-505 Update to throw exception when
the transaction timeout
URL: https://github.com/apache/incubator-servicecomb-saga/pull/175
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The service should throw the exception when the saga transaction is timeout
> ---------------------------------------------------------------------------
>
> Key: SCB-505
> URL: https://issues.apache.org/jira/browse/SCB-505
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
> Reporter: Zheng Feng
> Assignee: Zheng Feng
> Priority: Major
> Fix For: saga-0.2.0
>
>
> Currently, the service returns successfully when the transaction is timeout.
> I think we should check the return value when sending the SagaEndedEvent. if
> the response.aborted() is true, we need to throw the exception to show the
> message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
