[jira] [Commented] (SCB-505) The service should throw the exception when the saga transaction is timeout

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/SCB-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442675#comment-16442675
 ] 

ASF GitHub Bot commented on SCB-505:
------------------------------------

coveralls commented on issue #175: SCB-505 Update to throw exception when the 
transaction timeout
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16578966/badge)](https://coveralls.io/builds/16578966)
   
   Coverage decreased (-0.6%) to 94.919% when pulling 
**6638eb65a9a1107196c701400da7578395ba98e2 on zhfeng:SCB-505** into 
**87949e488ea1ec51f26cd284fe90b6bc35891c8b on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The service should throw the exception when the saga transaction is timeout
> ---------------------------------------------------------------------------
>
>                 Key: SCB-505
>                 URL: https://issues.apache.org/jira/browse/SCB-505
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Saga
>            Reporter: Zheng Feng
>            Assignee: Zheng Feng
>            Priority: Major
>             Fix For: saga-0.2.0
>
>
> Currently, the service returns successfully when the transaction is timeout. 
> I think we should check the return value when sending the SagaEndedEvent. if 
> the response.aborted() is true, we need to throw the exception to show the 
> message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)