[
https://issues.apache.org/jira/browse/SCB-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473706#comment-16473706
]
ASF GitHub Bot commented on SCB-548:
------------------------------------
liubao68 commented on a change in pull request #693: [SCB-548] support
gracefully shutdown
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r187825405
##########
File path:
core/src/main/java/org/apache/servicecomb/core/handler/ShutdownHookHandler.java
##########
@@ -62,36 +66,34 @@ public void handle(Invocation invocation, AsyncResponse
asyncResp) throws Except
}
// TODO:统计功能应该独立出来，在链中统计，会有各种bug
- // 下面的两次catch，可能会导致一次请求，对应2次应答
+ // 下面的两次catch，可能会导致一次请求，对应2次应答
requestCounter.incrementAndGet();
try {
invocation.next(resp -> {
try {
asyncResp.handle(resp);
} finally {
responseCounter.incrementAndGet();
+ validAllInvocationFinished();
}
});
} catch (Throwable e) {
responseCounter.incrementAndGet();
+ validAllInvocationFinished();
throw e;
}
}
+ private synchronized void validAllInvocationFinished() {
Review comment:
This synchronized code blocking all invocations and not good idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support Gracefully Shutdown
> ---------------------------
>
> Key: SCB-548
> URL: https://issues.apache.org/jira/browse/SCB-548
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m2
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
>
> We did not implement gracefully shutdown yet:
> ```java
> // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> // 1. 去注册实例信息
> // TODO 服务优雅退出
> if (applicationContext instanceof AbstractApplicationContext) {
> ((AbstractApplicationContext)
> applicationContext).registerShutdownHook();
> }
> ```
>
> And had got an issue :
> https://github.com/apache/incubator-servicecomb-java-chassis/issues/685 from
> user.
> So it's time we must do it and remove this TODO
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
