[
https://issues.apache.org/jira/browse/SCB-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473714#comment-16473714
]
ASF GitHub Bot commented on SCB-548:
------------------------------------
liubao68 commented on issue #693: [SCB-548] support gracefully shutdown
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388681843
@wujimin
ShutdownHookHandler is not so good, sometimes will block shutdown process
cause of wrong statistics, must depend on timeout to make shutdown process
continue. ----I don't know how this comes. Because
ShutdownHookHandler will wait quit a long time much more than the request
timeout. If the time reached there usually means timeout not properly set or
some other bug.
we should:
1.prevent create new consumer invocation ----This is have already done
2.prevent other find me ---We can not prevent it from actually happen and
maybe time delay.
3.make accurate statistics ---The process is shutdown and we force close
some unexpected invocations and I think the precision is not very important and
accurate statistics can not be achieved.
We are experiencing a lot of scenarios that can not be shutdown but need
force to exit the program. Program not exit can cause more bad consequences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support Gracefully Shutdown
> ---------------------------
>
> Key: SCB-548
> URL: https://issues.apache.org/jira/browse/SCB-548
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m2
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
>
> We did not implement gracefully shutdown yet:
> ```java
> // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> // 1. 去注册实例信息
> // TODO 服务优雅退出
> if (applicationContext instanceof AbstractApplicationContext) {
> ((AbstractApplicationContext)
> applicationContext).registerShutdownHook();
> }
> ```
>
> And had got an issue :
> https://github.com/apache/incubator-servicecomb-java-chassis/issues/685 from
> user.
> So it's time we must do it and remove this TODO
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
