[
https://issues.apache.org/jira/browse/SCB-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520223#comment-16520223
]
ASF GitHub Bot commented on SCB-685:
------------------------------------
acsukesh commented on a change in pull request #774: [SCB-685] Service comb
chassis must support default values in query parameters
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/774#discussion_r197407199
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/QueryProcessorCreator.java
##########
@@ -43,6 +54,12 @@ public Object getValue(HttpServletRequest request) throws
Exception {
value = request.getParameterValues(paramPath);
} else {
value = request.getParameter(paramPath);
+ if (value == null || value.equals("")) {
Review comment:
"" comes only when user inputs the same and is considered as valid input
parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Service comb chassis must support default values
> ------------------------------------------------
>
> Key: SCB-685
> URL: https://issues.apache.org/jira/browse/SCB-685
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: sukesh
> Assignee: sukesh
> Priority: Major
>
> adding default values using @RequestParam and @ApiImplicitParam annotations
> is not working as the same is not generated in swagger.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
