[
https://issues.apache.org/jira/browse/SCB-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522201#comment-16522201
]
ASF GitHub Bot commented on SCB-685:
------------------------------------
liubao68 commented on issue #774: [SCB-685] Service comb chassis must support
default values in query parameters
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/774#issuecomment-399927002
I'll merge this PR. Following work need to be done:
1. Support JAX-RS
2. Adding more test cases, to cover default values not specified and user do
not parse any value. See review comments: " Maybe it's better to return
ValueConstants.DEFAULT_NONE. When no default value specified and users do not
give the parameter value, we can throw an BadRequest exception or give default
value based on parameter type, e.g. int is 0 and String is null."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Service comb chassis must support default values
> ------------------------------------------------
>
> Key: SCB-685
> URL: https://issues.apache.org/jira/browse/SCB-685
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: sukesh
> Assignee: sukesh
> Priority: Major
>
> adding default values using @RequestParam and @ApiImplicitParam annotations
> is not working as the same is not generated in swagger.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
