[ 
https://issues.apache.org/jira/browse/SCB-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530653#comment-16530653
 ] 

ASF GitHub Bot commented on SCB-671:
------------------------------------

wujimin commented on a change in pull request #787: [SCB-671]duplicate cse to 
servicecomb
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/787#discussion_r199660196
 
 

 ##########
 File path: 
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/MicroserviceConfigLoader.java
 ##########
 @@ -28,7 +28,9 @@
 public class MicroserviceConfigLoader extends YAMLConfigLoader {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(MicroserviceConfigLoader.class);
 
-  private static final String ADDITIONAL_CONFIG_URL = 
"cse.configurationSource.additionalUrls";
+  private static final String ADDITIONAL_CONFIG_URL = 
"servicecomb.configurationSource.additionalUrls";
 
 Review comment:
   i remember someone already used this feature

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Duplicate cse.xxx to servicecomb.xxx to work better in future
> -------------------------------------------------------------
>
>                 Key: SCB-671
>                 URL: https://issues.apache.org/jira/browse/SCB-671
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Java-Chassis
>            Reporter: liubao
>            Assignee: liubao
>            Priority: Major
>             Fix For: java-chassis-1.0.0
>
>
> As discussed in 
> [DISCUSSION] How to migrate configurations from cse toservicecomb prefix
> It's better to map cse to servicecomb, not servicecomb to cse. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to