[
https://issues.apache.org/jira/browse/SCB-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530930#comment-16530930
]
ASF GitHub Bot commented on SCB-671:
------------------------------------
liubao68 commented on a change in pull request #787: [SCB-671]duplicate cse to
servicecomb
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/787#discussion_r199704187
##########
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/AbstractConfigLoader.java
##########
@@ -63,7 +63,16 @@ public ConfigModel load(URL url) throws IOException {
ConfigModel configModel = new ConfigModel();
configModel.setUrl(url);
configModel.setConfig(config);
- Object objOrder = config.get(orderKey);
+
+ Object objOrder = config.get(ORDER_KEY);
+ if (objOrder == null) {
+ // compatible check
+ objOrder = config.get("cse-config-order");
+ if (objOrder != null) {
+ LOGGER.error("cse-config-order will not be supported in future, please
change it to servicecomb-config-order");
Review comment:
This is quick fix for users, so I give error not warning. Users see this, it
quite important to fix it immediately. Some others like above duplicate key, I
give warning, as users can not change common modules.
I am thinking of throw an exception here, just like
cse.configurationSource.additionalUrls do, but after quite a lot consideration,
give an error message is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Duplicate cse.xxx to servicecomb.xxx to work better in future
> -------------------------------------------------------------
>
> Key: SCB-671
> URL: https://issues.apache.org/jira/browse/SCB-671
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: liubao
> Assignee: liubao
> Priority: Major
> Fix For: java-chassis-1.0.0
>
>
> As discussed in
> [DISCUSSION] How to migrate configurations from cse toservicecomb prefix
> It's better to map cse to servicecomb, not servicecomb to cse.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
