[
https://issues.apache.org/jira/browse/SCB-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547469#comment-16547469
]
ASF GitHub Bot commented on SCB-754:
------------------------------------
yhs0092 opened a new pull request #817: [SCB-754] add null pointer check on
AbstractRestInvocation.invocation
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/817
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
See details in [SCB-754](https://issues.apache.org/jira/browse/SCB-754)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Check null invocation in AbstractRestInvocation to avoid unexpected NPE
> -----------------------------------------------------------------------
>
> Key: SCB-754
> URL: https://issues.apache.org/jira/browse/SCB-754
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> In a 404 situation, the invocation in AbstractRestInvocation is not
> initialized. Once user defines a custom HttpServerFilter and thrown an
> Exception in it's beforeSendResponse method, the AbstractRestInvocation will
> throw a NPE because in it's error log code, invocation is invoked without
> null check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
