[ 
https://issues.apache.org/jira/browse/SCB-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547671#comment-16547671
 ] 

ASF GitHub Bot commented on SCB-754:
------------------------------------

coveralls edited a comment on issue #817: [SCB-754] add null pointer check on 
AbstractRestInvocation.invocation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/817#issuecomment-405836488
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/18041249/badge)](https://coveralls.io/builds/18041249)
   
   Coverage increased (+0.003%) to 87.052% when pulling 
**166181b4817b7f7f68f6a3ca9cf28700cafec721 on yhs0092:check_null_invocation** 
into **a18ab097030f4bb6ec3bd30942de57102f5694a9 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Check null invocation in AbstractRestInvocation to avoid unexpected NPE
> -----------------------------------------------------------------------
>
>                 Key: SCB-754
>                 URL: https://issues.apache.org/jira/browse/SCB-754
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Java-Chassis
>            Reporter: YaoHaishi
>            Assignee: YaoHaishi
>            Priority: Major
>             Fix For: java-chassis-1.1.0
>
>
> In a 404 situation, the invocation in AbstractRestInvocation is not 
> initialized. Once user defines a custom HttpServerFilter and thrown an 
> Exception in it's beforeSendResponse method, the AbstractRestInvocation will 
> throw a NPE because in it's error log code, invocation is invoked without 
> null check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to