[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574297#comment-16574297
 ] 

ASF GitHub Bot commented on SCB-736:
------------------------------------

maheshrajus commented on a change in pull request #863: [SCB-736] generate 
default value to swagger for primitive type when there is no defaultValue 
annotation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/863#discussion_r208807437
 
 

 ##########
 File path: 
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/OperationGenerator.java
 ##########
 @@ -315,8 +315,30 @@ protected void processByParameterAnnotation(Annotation[] 
paramAnnotations, int p
         }
       }
     }
-    if (parameter instanceof AbstractSerializableParameter && defaultValue != 
null) {
-      ((AbstractSerializableParameter<?>) 
parameter).setDefaultValue(defaultValue);
+    if (parameter instanceof AbstractSerializableParameter) {
+      if (defaultValue != null) {
+        ((AbstractSerializableParameter<?>) 
parameter).setDefaultValue(defaultValue);
+      } else if ((((AbstractSerializableParameter<?>) 
parameter).getDefaultValue() == null)
+          && (false == ((AbstractSerializableParameter<?>) 
parameter).getRequired())) { //if required false then only take java primitive 
values as defaults
 
 Review comment:
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> generate default value to swagger for primitive type, even there is no 
> defaultValue annotation
> ----------------------------------------------------------------------------------------------
>
>                 Key: SCB-736
>                 URL: https://issues.apache.org/jira/browse/SCB-736
>             Project: Apache ServiceComb
>          Issue Type: Task
>          Components: Java-Chassis
>            Reporter: wujimin
>            Assignee: Mahesh Raju Somalaraju
>            Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i,  boolean b) {
>   return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)