[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579305#comment-16579305
]
ASF GitHub Bot commented on SCB-736:
------------------------------------
liubao68 closed pull request #863: [SCB-736] generate default value to swagger
for primitive type when there is no defaultValue annotation
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/863
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
index a2b129b0f..f285d5fc0 100644
---
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
+++
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
@@ -38,7 +38,6 @@
import org.apache.servicecomb.foundation.common.utils.BeanUtils;
import org.apache.servicecomb.foundation.common.utils.Log4jUtils;
import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
-import org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory;
import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
import org.springframework.http.HttpEntity;
import org.springframework.http.HttpHeaders;
@@ -72,6 +71,7 @@ public static void run() throws Exception {
testValidator(templateNew);
testClientTimeOut(templateNew);
testJaxRSDefaultValues(templateNew);
+ testSpringMvcDefaultValuesJavaPrimitive(templateNew);
MultiErrorCodeServiceClient.runTest();
BeanParamPojoClient beanParamPojoClient = new BeanParamPojoClient();
@@ -143,7 +143,7 @@ private static void testJaxRSDefaultValues(RestTemplate
template) {
result = template.getForObject(cseUrlPrefix + "/query2", String.class);
} catch (InvocationException e) {
failed = true;
- TestMgr.check(e.getStatusCode(),
ExceptionFactory.PRODUCER_INNER_STATUS_CODE);
+ TestMgr.check(e.getStatusCode(), HttpStatus.SC_BAD_REQUEST);
}
failed = false;
@@ -408,4 +408,27 @@ private static void testClientTimeoutAdd(RestTemplate
template, String cseUrlPre
TestMgr.check(true, isExcep);
}
+
+ private static void testSpringMvcDefaultValuesJavaPrimitive(RestTemplate
template) {
+ String microserviceName = "jaxrs";
+ String cseUrlPrefix = "cse://" + microserviceName + "/JaxRSDefaultValues/";
+
+ HttpHeaders headers = new HttpHeaders();
+
headers.setContentType(org.springframework.http.MediaType.APPLICATION_FORM_URLENCODED);
+ MultiValueMap<String, String> map = new LinkedMultiValueMap<>();
+ HttpEntity<MultiValueMap<String, String>> request = new HttpEntity<>(map,
headers);
+
+ //default values with primitive
+ String result = template.postForObject(cseUrlPrefix + "/javaprimitiveint",
request, String.class);
+ TestMgr.check("Hello 0bobo", result);
+
+ result = template.postForObject(cseUrlPrefix + "/javaprimitivenumber",
request, String.class);
+ TestMgr.check("Hello 0.0false", result);
+
+ result = template.postForObject(cseUrlPrefix + "/javaprimitivestr",
request, String.class);
+ TestMgr.check("Hello", result);
+
+ result = template.postForObject(cseUrlPrefix + "/javaprimitivecomb",
request, String.class);
+ TestMgr.check("Hello 00.0", result);
+ }
}
diff --git
a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/JaxRSDefaultValues.java
b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/JaxRSDefaultValues.java
index 7889e5411..aa8f461dc 100644
---
a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/JaxRSDefaultValues.java
+++
b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/JaxRSDefaultValues.java
@@ -88,4 +88,34 @@ public String queryPackages(HttpServletRequest httpRequest,
return "" + appType;
}
+ @Path("/javaprimitiveint")
+ @POST
+ @Consumes(MediaType.APPLICATION_FORM_URLENCODED)
+ public String jaxRsJavaPrimitiveInt(@FormParam("a") int a,
@DefaultValue("bobo") @FormParam("b") String b) {
+ return "Hello " + a + b;
+ }
+
+ @Path("/javaprimitivenumber")
+ @POST
+ @Consumes(MediaType.APPLICATION_FORM_URLENCODED)
+ public String jaxRsJavaPrimitiveNumber(@QueryParam("a") float a,
@QueryParam("b") boolean b) {
+ return "Hello " + a + b;
+ }
+
+ @Path("/javaprimitivestr")
+ @POST
+ @Consumes(MediaType.APPLICATION_FORM_URLENCODED)
+ public String jaxRsJavaPrimitiveStr(@FormParam("b") int b, @FormParam("a")
String a) {
+ if (a == null || a.equals("")) {
+ return "Hello";
+ }
+ return "Hello " + b + a;
+ }
+
+ @Path("/javaprimitivecomb")
+ @POST
+ @Consumes(MediaType.APPLICATION_FORM_URLENCODED)
+ public String jaxRsJavaPrimitiveCombnation(@QueryParam("a") Integer a,
@QueryParam("b") Float b) {
+ return "Hello " + a + b;
+ }
}
diff --git
a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
index beab26a74..a555fc9b5 100644
---
a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
+++
b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
@@ -32,7 +32,6 @@
import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
import
org.apache.servicecomb.provider.springmvc.reference.UrlWithProviderPrefixClientHttpRequestFactory;
import
org.apache.servicecomb.provider.springmvc.reference.UrlWithServiceNameClientHttpRequestFactory;
-import org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory;
import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
import org.springframework.http.HttpEntity;
import org.springframework.http.HttpHeaders;
@@ -96,6 +95,7 @@ public static void run() {
testController();
testRequiredBody(templateUrlWithServiceName, microserviceName);
testSpringMvcDefaultValues(templateUrlWithServiceName, microserviceName);
+ testSpringMvcDefaultValuesJavaPrimitive(templateUrlWithServiceName,
microserviceName);
}
HttpHeaders headers = new HttpHeaders();
headers.set("Accept-Encoding", "gzip");
@@ -289,7 +289,7 @@ private static void testSpringMvcDefaultValues(RestTemplate
template, String mic
result = template.getForObject(cseUrlPrefix + "/query2", String.class);
} catch (InvocationException e) {
failed = true;
- TestMgr.check(e.getStatusCode(),
ExceptionFactory.PRODUCER_INNER_STATUS_CODE);
+ TestMgr.check(e.getStatusCode(), HttpStatus.SC_BAD_REQUEST);
}
failed = false;
@@ -346,4 +346,20 @@ private static void
testSpringMvcDefaultValues(RestTemplate template, String mic
result = template.getForObject(cseUrlPrefix +
"/query2?a=3&b=4&c=5&d=30&e=2", String.class);
TestMgr.check("Hello 345302", result);
}
+
+ private static void testSpringMvcDefaultValuesJavaPrimitive(RestTemplate
template, String microserviceName) {
+ String cseUrlPrefix = "cse://" + microserviceName +
"/SpringMvcDefaultValues/";
+ //default values with primitive
+ String result = template.postForObject(cseUrlPrefix + "/javaprimitiveint",
null, String.class);
+ TestMgr.check("Hello 0bobo", result);
+
+ result = template.postForObject(cseUrlPrefix + "/javaprimitivenumber",
null, String.class);
+ TestMgr.check("Hello 0.0false", result);
+
+ result = template.postForObject(cseUrlPrefix + "/javaprimitivestr", null,
String.class);
+ TestMgr.check("Hello", result);
+
+ result = template.postForObject(cseUrlPrefix + "/javaprimitivecomb", null,
String.class);
+ TestMgr.check("Hello 00.0", result);
+ }
}
diff --git
a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/ProducerTestsAfterBootup.java
b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/ProducerTestsAfterBootup.java
index 1c12b407f..ce80bf803 100644
---
a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/ProducerTestsAfterBootup.java
+++
b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/ProducerTestsAfterBootup.java
@@ -53,9 +53,9 @@ public void testSchemaNotChange() {
CodeFirstSpringmvcForSchema.class,
new CodeFirstSpringmvcForSchema());
String codeFirst = getSwaggerContent(meta.getSwagger());
-
TestMgr.check("07a48acef4cc1a7f2387d695923c49e98951a974e4f51cf1356d6878db48888f",
+
TestMgr.check("4d18e9b339136d68c7e5e83f4f302664c91465d9747a36334841e082d336516e",
RegistryUtils.calcSchemaSummary(codeFirst));
- TestMgr.check(codeFirst.length(), 899);
+ TestMgr.check(codeFirst.length(), 896);
}
public void testRegisterPath() {
diff --git
a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/SpringMvcDefaultValues.java
b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/SpringMvcDefaultValues.java
index b2f372365..1c99505ae 100644
---
a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/SpringMvcDefaultValues.java
+++
b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/SpringMvcDefaultValues.java
@@ -52,10 +52,10 @@ public String query(@RequestParam(name = "a", defaultValue
= "20") int a,
}
@GetMapping("/query2")
- public String query2(@RequestParam("e") int e, @RequestParam(name = "a",
defaultValue = "20") int a,
+ public String query2(@RequestParam(name = "e", required = false) int e,
@RequestParam(name = "a", defaultValue = "20") int a,
@RequestParam(name = "b", defaultValue = "bobo") String b,
@RequestParam(name = "c", defaultValue = "40") Integer c,
- @Min(value = 20) @Max(value = 30) @RequestParam("d") int d) {
+ @Min(value = 20) @Max(value = 30) @RequestParam(name = "d", required =
false) int d) {
return "Hello " + a + b + c + d + e;
}
@@ -64,4 +64,28 @@ public String query3(@RequestParam("a") @Min(value = 20) int
a, @RequestParam("b
return "Hello " + a + b;
}
+ @PostMapping("/javaprimitiveint")
+ public String springJavaPrimitiveInt(@RequestParam(name = "a", required =
false) int a,
+ @RequestParam(name = "b", defaultValue = "bobo") String b) {
+ return "Hello " + a + b;
+ }
+
+ @PostMapping("/javaprimitivenumber")
+ public String springJavaPrimitiveNumber(@RequestParam(name = "a", required =
false) float a, @RequestParam(name = "b", required = false) boolean b) {
+ return "Hello " + a + b;
+ }
+
+ @PostMapping("/javaprimitivestr")
+ public String springJavaPrimitiveStr(@RequestParam(name = "a", required =
false) int a, @RequestParam(name = "b", required = false) String b) {
+ if (b == null || b.equals("")) {
+ return "Hello";
+ }
+ return "Hello " + b + a;
+
+ }
+
+ @PostMapping("/javaprimitivecomb")
+ public String springJavaPrimitiveCombination(@RequestParam(name = "a",
required = false) Integer a, @RequestParam(name = "b", required = false) Float
b) {
+ return "Hello " + a + b;
+ }
}
diff --git
a/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/OperationGenerator.java
b/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/OperationGenerator.java
index ba0b90008..8698585c7 100644
---
a/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/OperationGenerator.java
+++
b/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/OperationGenerator.java
@@ -315,8 +315,30 @@ protected void processByParameterAnnotation(Annotation[]
paramAnnotations, int p
}
}
}
- if (parameter instanceof AbstractSerializableParameter && defaultValue !=
null) {
- ((AbstractSerializableParameter<?>)
parameter).setDefaultValue(defaultValue);
+ if (parameter instanceof AbstractSerializableParameter) {
+ if (defaultValue != null) {
+ ((AbstractSerializableParameter<?>)
parameter).setDefaultValue(defaultValue);
+ } else if ((((AbstractSerializableParameter<?>)
parameter).getDefaultValue() == null)
+ && (!((AbstractSerializableParameter<?>) parameter).getRequired()))
{ //if required false then only take java primitive values as defaults
+ String type = ((AbstractSerializableParameter<?>) parameter).getType();
+ switch (type) {
+ case "integer":
+ defaultValue = "0";
+ break;
+ case "number":
+ defaultValue = "0.0";
+ break;
+ case "string":
+ defaultValue = "";
+ break;
+ case "boolean":
+ defaultValue = "false";
+ break;
+ default:
+ defaultValue = null;
+ }
+ ((AbstractSerializableParameter<?>)
parameter).setDefaultValue(defaultValue);
+ }
}
}
diff --git
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/CookieValueAnnotationProcessor.java
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/CookieValueAnnotationProcessor.java
index 8dc61eacd..a86ea06bb 100644
---
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/CookieValueAnnotationProcessor.java
+++
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/CookieValueAnnotationProcessor.java
@@ -17,6 +17,7 @@
package
org.apache.servicecomb.swagger.generator.springmvc.processor.annotation;
+import org.apache.servicecomb.swagger.generator.core.OperationGenerator;
import
org.apache.servicecomb.swagger.generator.core.processor.parameter.AbstractParameterProcessor;
import org.springframework.web.bind.annotation.CookieValue;
import org.springframework.web.bind.annotation.ValueConstants;
@@ -34,6 +35,15 @@ public CookieParameter createParameter() {
return new CookieParameter();
}
+ @Override
+ protected void fillParameter(Object annotation, OperationGenerator
operationGenerator, int paramIdx,
+ CookieParameter parameter) {
+ super.fillParameter(annotation, operationGenerator, paramIdx, parameter);
+
+ CookieValue cookie = (CookieValue) annotation;
+ parameter.setRequired(cookie.required());
+ }
+
@Override
protected String getAnnotationParameterDefaultValue(Object annotation) {
String defaultValue = ((CookieValue) annotation).defaultValue();
diff --git
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/PathVariableAnnotationProcessor.java
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/PathVariableAnnotationProcessor.java
index e77b7785e..6297ef775 100644
---
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/PathVariableAnnotationProcessor.java
+++
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/PathVariableAnnotationProcessor.java
@@ -17,6 +17,7 @@
package
org.apache.servicecomb.swagger.generator.springmvc.processor.annotation;
+import org.apache.servicecomb.swagger.generator.core.OperationGenerator;
import
org.apache.servicecomb.swagger.generator.core.processor.parameter.AbstractParameterProcessor;
import org.springframework.web.bind.annotation.PathVariable;
@@ -32,4 +33,13 @@ public PathParameter createParameter() {
public String getAnnotationParameterName(Object annotation) {
return ((PathVariable) annotation).value();
}
+
+ @Override
+ protected void fillParameter(Object annotation, OperationGenerator
operationGenerator, int paramIdx,
+ PathParameter parameter) {
+ super.fillParameter(annotation, operationGenerator, paramIdx, parameter);
+
+ PathVariable pathVariable = (PathVariable) annotation;
+ parameter.setRequired(pathVariable.required());
+ }
}
diff --git
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestAttributeAnnotationProcessor.java
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestAttributeAnnotationProcessor.java
index 09e5f379b..0166a762a 100644
---
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestAttributeAnnotationProcessor.java
+++
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestAttributeAnnotationProcessor.java
@@ -17,6 +17,7 @@
package
org.apache.servicecomb.swagger.generator.springmvc.processor.annotation;
+import org.apache.servicecomb.swagger.generator.core.OperationGenerator;
import
org.apache.servicecomb.swagger.generator.core.processor.parameter.AbstractParameterProcessor;
import org.springframework.web.bind.annotation.RequestAttribute;
@@ -32,4 +33,13 @@ public FormParameter createParameter() {
public String getAnnotationParameterName(Object annotation) {
return ((RequestAttribute) annotation).name();
}
+
+ @Override
+ protected void fillParameter(Object annotation, OperationGenerator
operationGenerator, int paramIdx,
+ FormParameter parameter) {
+ super.fillParameter(annotation, operationGenerator, paramIdx, parameter);
+
+ RequestAttribute requestAttribute = (RequestAttribute) annotation;
+ parameter.setRequired(requestAttribute.required());
+ }
}
diff --git
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestParamAnnotationProcessor.java
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestParamAnnotationProcessor.java
index d839c1caf..a32274bfb 100644
---
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestParamAnnotationProcessor.java
+++
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestParamAnnotationProcessor.java
@@ -17,6 +17,7 @@
package
org.apache.servicecomb.swagger.generator.springmvc.processor.annotation;
+import org.apache.servicecomb.swagger.generator.core.OperationGenerator;
import
org.apache.servicecomb.swagger.generator.core.processor.parameter.AbstractParameterProcessor;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.ValueConstants;
@@ -34,6 +35,15 @@ public String getAnnotationParameterName(Object annotation) {
return ((RequestParam) annotation).name();
}
+ @Override
+ protected void fillParameter(Object annotation, OperationGenerator
operationGenerator, int paramIdx,
+ QueryParameter parameter) {
+ super.fillParameter(annotation, operationGenerator, paramIdx, parameter);
+
+ RequestParam requestParam = (RequestParam) annotation;
+ parameter.setRequired(requestParam.required());
+ }
+
@Override
protected String getAnnotationParameterDefaultValue(Object annotation) {
String defaultValue = ((RequestParam) annotation).defaultValue();
diff --git
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestPartAnnotationProcessor.java
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestPartAnnotationProcessor.java
index 39017526d..fe3ec24ca 100644
---
a/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestPartAnnotationProcessor.java
+++
b/swagger/swagger-generator/generator-springmvc/src/main/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestPartAnnotationProcessor.java
@@ -17,6 +17,7 @@
package
org.apache.servicecomb.swagger.generator.springmvc.processor.annotation;
+import org.apache.servicecomb.swagger.generator.core.OperationGenerator;
import
org.apache.servicecomb.swagger.generator.core.processor.parameter.AbstractParameterProcessor;
import org.springframework.web.bind.annotation.RequestPart;
@@ -32,4 +33,13 @@ public FormParameter createParameter() {
public String getAnnotationParameterName(Object annotation) {
return ((RequestPart) annotation).name();
}
+
+ @Override
+ protected void fillParameter(Object annotation, OperationGenerator
operationGenerator, int paramIdx,
+ FormParameter parameter) {
+ super.fillParameter(annotation, operationGenerator, paramIdx, parameter);
+
+ RequestPart requestPart = (RequestPart) annotation;
+ parameter.setRequired(requestPart.required());
+ }
}
diff --git
a/swagger/swagger-generator/generator-springmvc/src/test/resources/schemas/mixupAnnotations.yaml
b/swagger/swagger-generator/generator-springmvc/src/test/resources/schemas/mixupAnnotations.yaml
index a31e9e23a..fc9f3802c 100644
---
a/swagger/swagger-generator/generator-springmvc/src/test/resources/schemas/mixupAnnotations.yaml
+++
b/swagger/swagger-generator/generator-springmvc/src/test/resources/schemas/mixupAnnotations.yaml
@@ -52,11 +52,11 @@ paths:
type: "string"
- name: "word"
in: "query"
- required: false
+ required: true
type: "string"
- name: "form"
in: "formData"
- required: false
+ required: true
type: "string"
responses:
200:
@@ -88,11 +88,11 @@ paths:
type: "string"
- name: "word"
in: "query"
- required: false
+ required: true
type: "string"
- name: "form"
in: "formData"
- required: false
+ required: true
type: "string"
responses:
200:
@@ -124,11 +124,11 @@ paths:
type: "string"
- name: "word"
in: "query"
- required: false
+ required: true
type: "string"
- name: "form"
in: "formData"
- required: false
+ required: true
type: "string"
responses:
200:
@@ -160,11 +160,11 @@ paths:
type: "string"
- name: "word"
in: "query"
- required: false
+ required: true
type: "string"
- name: "form"
in: "formData"
- required: false
+ required: true
type: "string"
responses:
200:
@@ -196,11 +196,11 @@ paths:
type: "string"
- name: "word"
in: "query"
- required: false
+ required: true
type: "string"
- name: "form"
in: "formData"
- required: false
+ required: true
type: "string"
responses:
200:
@@ -232,11 +232,11 @@ paths:
type: "string"
- name: "word"
in: "query"
- required: false
+ required: true
type: "string"
- name: "form"
in: "formData"
- required: false
+ required: true
type: "string"
responses:
200:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> ----------------------------------------------------------------------------------------------
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: Mahesh Raju Somalaraju
> Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
