[
https://issues.apache.org/jira/browse/SCB-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581428#comment-16581428
] ASF GitHub Bot commented on SCB-848: ------------------------------------ codecov-io commented on issue #416: SCB-848 Uses zap to replace the paas-lager URL: https://github.com/apache/incubator-servicecomb-service-center/pull/416#issuecomment-413284340 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=h1) Report > Merging [#416](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/447a47ad72afbcca2c175701bd8d57cb068b734d?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `62.75%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #416 +/- ## ========================================== + Coverage 73.2% 73.21% +<.01% ========================================== Files 124 126 +2 Lines 9917 9894 -23 ========================================== - Hits 7260 7244 -16 + Misses 2180 2171 -9 - Partials 477 479 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/util/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `61.11% <ø> (-7.08%)` | :arrow_down: | | [pkg/util/reflect.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL3V0aWwvcmVmbGVjdC5nbw==) | `78.68% <ø> (ø)` | :arrow_up: | | [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `66.03% <0%> (ø)` | :arrow_up: | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `61.19% <0%> (ø)` | :arrow_up: | | [server/govern/controller\_v4.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9jb250cm9sbGVyX3Y0Lmdv) | `73.49% <0%> (ø)` | :arrow_up: | | [server/service/validate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=) | `84.48% <0%> (ø)` | :arrow_up: | | [server/plugin/infra/tracing/buildin/buildin.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vYnVpbGRpbi5nbw==) | `86% <0%> (ø)` | :arrow_up: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (ø)` | | | [server/plugin/infra/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vY29tbW9uLmdv) | `50% <0%> (ø)` | :arrow_up: | | [pkg/queue/uniqueue.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL3F1ZXVlL3VuaXF1ZXVlLmdv) | `87.5% <0%> (ø)` | | | ... and [60 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=footer). Last update [447a47a...f6b5e6e](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] > Uses zap to replace the paas-lager > ---------------------------------- > > Key: SCB-848 > URL: https://issues.apache.org/jira/browse/SCB-848 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
