[ 
https://issues.apache.org/jira/browse/SCB-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582137#comment-16582137
 ] 

ASF GitHub Bot commented on SCB-848:
------------------------------------

codecov-io edited a comment on issue #416: SCB-848 Uses zap to replace the 
paas-lager
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/416#issuecomment-413284340
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=h1)
 Report
   > Merging 
[#416](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7f4fb650fb03f81a31b7cb1b97d217ee9a10ee37?src=pr&el=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `65.58%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/graphs/tree.svg?token=GAaF7zrg8R&width=650&src=pr&height=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #416      +/-   ##
   ==========================================
   - Coverage   73.14%   72.99%   -0.15%     
   ==========================================
     Files         124      128       +4     
     Lines        9889     9976      +87     
   ==========================================
   + Hits         7233     7282      +49     
   - Misses       2177     2217      +40     
   + Partials      479      477       -2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/util/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==)
 | `61.11% <ø> (-7.08%)` | :arrow_down: |
   | 
[pkg/util/sys.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL3V0aWwvc3lzLmdv)
 | `91.66% <ø> (-0.34%)` | :arrow_down: |
   | 
[pkg/util/reflect.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL3V0aWwvcmVmbGVjdC5nbw==)
 | `78.68% <ø> (ø)` | :arrow_up: |
   | 
[server/service/validate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=)
 | `84.48% <0%> (ø)` | :arrow_up: |
   | 
[server/plugin/infra/quota/buildin/buildin.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9xdW90YS9idWlsZGluL2J1aWxkaW4uZ28=)
 | `11.76% <0%> (ø)` | |
   | 
[server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==)
 | `66.03% <0%> (ø)` | :arrow_up: |
   | 
[pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=)
 | `33.71% <0%> (ø)` | |
   | 
[server/plugin/infra/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vY29tbW9uLmdv)
 | `50% <0%> (ø)` | :arrow_up: |
   | 
[server/core/backend/backend.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9iYWNrZW5kLmdv)
 | `34.88% <0%> (ø)` | :arrow_up: |
   | 
[server/plugin/infra/tracing/buildin/buildin.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vYnVpbGRpbi5nbw==)
 | `86% <0%> (ø)` | :arrow_up: |
   | ... and [65 
more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=footer).
 Last update 
[7f4fb65...eb44f58](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Uses zap to replace the paas-lager
> ----------------------------------
>
>                 Key: SCB-848
>                 URL: https://issues.apache.org/jira/browse/SCB-848
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Service-Center
>            Reporter: little-cui
>            Assignee: little-cui
>            Priority: Major
>             Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to