[
https://issues.apache.org/jira/browse/SCB-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592275#comment-16592275
]
ASF GitHub Bot commented on SCB-865:
------------------------------------
WillemJiang commented on a change in pull request #268: SCB-865 Implement
reaction of the event in Alpha Server
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/268#discussion_r212770993
##########
File path:
alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/tcc/OmegaCallbacksRegistry.java
##########
@@ -32,6 +33,10 @@
private final static Map<String, Map<String, OmegaCallback>> REGISTRY = new
ConcurrentHashMap<>();
Review comment:
Please don't use the static Map as the registry, it could introduce lots of
trouble here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring the Omega Interceptors
> ----------------------------------
>
> Key: SCB-865
> URL: https://issues.apache.org/jira/browse/SCB-865
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Reporter: Willem Jiang
> Priority: Major
>
> Current Omega transaction has two saga interceptors, one is for SagaStart,
> the other is for Compensable. As these two interceptor has different context
> to deal with, they are not supposed to share the same interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
