[
https://issues.apache.org/jira/browse/SCB-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592276#comment-16592276
]
ASF GitHub Bot commented on SCB-865:
------------------------------------
WillemJiang commented on a change in pull request #268: SCB-865 Implement
reaction of the event in Alpha Server
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/268#discussion_r212771101
##########
File path:
alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/tcc/OmegaCallbacksRegistry.java
##########
@@ -50,9 +55,18 @@ public static void register(GrpcServiceConfig request,
StreamObserver<GrpcTccCoo
* @param serviceName service name
* @param instanceId instance id
* @return Grpc omega TCC callback
+ * @throws AlphaException trigger this exception while missing omega
callback by service name
*/
- public static OmegaCallback retrieve(String serviceName, String instanceId) {
- return REGISTRY.getOrDefault(serviceName, emptyMap()).get(instanceId);
+ public static OmegaCallback retrieve(String serviceName, String instanceId)
throws AlphaException {
Review comment:
I don't think these method should be static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring the Omega Interceptors
> ----------------------------------
>
> Key: SCB-865
> URL: https://issues.apache.org/jira/browse/SCB-865
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Reporter: Willem Jiang
> Priority: Major
>
> Current Omega transaction has two saga interceptors, one is for SagaStart,
> the other is for Compensable. As these two interceptor has different context
> to deal with, they are not supposed to share the same interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
