[
https://issues.apache.org/jira/browse/SCB-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618354#comment-16618354
]
ASF GitHub Bot commented on SCB-916:
------------------------------------
WillemJiang closed pull request #300: SCB-916 Clean up @order annotation in
TransactionAspectConfig.
URL: https://github.com/apache/incubator-servicecomb-saga/pull/300
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionAspectConfig.java
b/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionAspectConfig.java
index 92d8bf42..f9a23d0d 100644
---
a/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionAspectConfig.java
+++
b/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionAspectConfig.java
@@ -33,7 +33,6 @@
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.EnableAspectJAutoProxy;
-import org.springframework.core.annotation.Order;
@Configuration
@EnableAspectJAutoProxy
@@ -45,13 +44,11 @@ MessageHandler messageHandler(MessageSender sender,
return new CompensationMessageHandler(sender, context);
}
- @Order(0)
@Bean
SagaStartAspect sagaStartAspect(MessageSender sender, OmegaContext context) {
return new SagaStartAspect(sender, context);
}
- @Order(1)
@Bean
TransactionAspect transactionAspect(MessageSender sender, OmegaContext
context) {
return new TransactionAspect(sender, context);
@@ -72,13 +69,11 @@ CompensableAnnotationProcessor
compensableAnnotationProcessor(OmegaContext omega
return new CoordinateMessageHandler(tccEventService, coordinateContext,
omegaContext, parametersContext);
}
- @Order(0)
@Bean
TccStartAspect tccStartAspect(TccEventService tccEventService, OmegaContext
context) {
return new TccStartAspect(tccEventService, context);
}
- @Order(1)
@Bean
TccParticipatorAspect tccParticipatorAspect(TccEventService tccEventService,
OmegaContext context, ParametersContext parametersContext) {
return new TccParticipatorAspect(tccEventService, context,
parametersContext);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clean up @order annotation in TransactionAspectConfig
> -----------------------------------------------------
>
> Key: SCB-916
> URL: https://issues.apache.org/jira/browse/SCB-916
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Affects Versions: saga-0.3.0
> Reporter: cherrylzhao
> Assignee: cherrylzhao
> Priority: Major
> Fix For: saga-0.3.0
>
>
> @order annotation can’t work in TransactionAspectConfig.java.
> Now, we define the @order(0), @order(1) in Aspect beans, but when I adjust
> the value of order,
> The aspect chains of dynamic proxy bean can’t change.
> Normally we just need
> make sure @Transactional Aspect is last one to the wrapper, so we'd like to
> clean up the @order annotation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
