[
https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651859#comment-16651859
]
ASF GitHub Bot commented on SCB-953:
------------------------------------
codecov-io commented on issue #458: SCB-953 Support sync distinct Kubernetes
service types to service-center
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510
#
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=h1)
Report
> Merging
[#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 60.18% 60.19% +<.01%
==========================================
Files 156 156
Lines 13411 13411
==========================================
+ Hits 8072 8073 +1
Misses 4760 4760
+ Partials 579 578 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==)
| `81.25% <0%> (-3.13%)` | :arrow_down: |
|
[pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=)
| `33.71% <0%> (-0.58%)` | :arrow_down: |
|
[server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv)
| `57.94% <0%> (+0.15%)` | :arrow_up: |
|
[server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv)
| `73.66% <0%> (+0.33%)` | :arrow_up: |
|
[...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv)
| `64.07% <0%> (+0.97%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=footer).
Last update
[8ddbc2f...bc24da1](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support sync distinct Kubernetes service types to service-center
> ----------------------------------------------------------------
>
> Key: SCB-953
> URL: https://issues.apache.org/jira/browse/SCB-953
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
