[
https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653136#comment-16653136
] ASF GitHub Bot commented on SCB-953: ------------------------------------ codecov-io edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=h1) Report > Merging [#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #458 +/- ## ========================================== + Coverage 60.18% 60.21% +0.02% ========================================== Files 156 156 Lines 13411 13411 ========================================== + Hits 8072 8076 +4 Misses 4760 4760 + Partials 579 575 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.86% <0%> (+0.59%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `61.19% <0%> (+1.49%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=footer). Last update [8ddbc2f...2400e1c](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] > Support sync distinct Kubernetes service types to service-center > ---------------------------------------------------------------- > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
