[
https://issues.apache.org/jira/browse/SCB-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679254#comment-16679254
]
ASF GitHub Bot commented on SCB-891:
------------------------------------
WillemJiang commented on a change in pull request #314: [SCB-891] Add kamon
metrics to Omega client
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/314#discussion_r231755224
##########
File path:
omega/omega-transport/omega-transport-dubbo/src/main/java/org/apache/servicecomb/saga/omega/transport/dubbo/SagaDubboConsumerFilter.java
##########
@@ -36,10 +36,14 @@
import static
org.apache.servicecomb.saga.omega.context.OmegaContext.GLOBAL_TX_ID_KEY;
import static
org.apache.servicecomb.saga.omega.context.OmegaContext.LOCAL_TX_ID_KEY;
+import kamon.annotation.EnableKamon;
+import kamon.annotation.Trace;
+
/**
* add saga transaction id to dubbo invocation
*/
@Activate(group = {Constants.CONSUMER})
+@EnableKamon
Review comment:
As there is no much work on the transport level, we don't need to add the
tag here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add kamon metrics to Omega client
> ---------------------------------
>
> Key: SCB-891
> URL: https://issues.apache.org/jira/browse/SCB-891
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Reporter: Mahesh Raju Somalaraju
> Assignee: Mahesh Raju Somalaraju
> Priority: Major
> Fix For: saga-0.3.0
>
>
> Need to add Kamon traces/metrics to omega client.
> Need to find the major flows in omega client side and need to add the kamon
> annotations for traces/metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
