[
https://issues.apache.org/jira/browse/SCB-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683264#comment-16683264
]
ASF GitHub Bot commented on SCB-891:
------------------------------------
maheshrajus commented on a change in pull request #314: [SCB-891] Add kamon
metrics to Omega client
URL: https://github.com/apache/servicecomb-saga/pull/314#discussion_r232543741
##########
File path: saga-demo/saga-spring-demo/pom.xml
##########
@@ -43,5 +43,39 @@
<groupId>io.netty</groupId>
<artifactId>netty-tcnative-boringssl-static</artifactId>
</dependency>
+ <!-- for the performance monitor -->
+ <dependency>
+ <groupId>io.kamon</groupId>
+ <artifactId>kamon-core_2.12</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.kamon</groupId>
+ <artifactId>kamon-annotation_2.12</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.typesafe.akka</groupId>
Review comment:
I tested it, without this dependency it is not working
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add kamon metrics to Omega client
> ---------------------------------
>
> Key: SCB-891
> URL: https://issues.apache.org/jira/browse/SCB-891
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Reporter: Mahesh Raju Somalaraju
> Assignee: Mahesh Raju Somalaraju
> Priority: Major
> Fix For: saga-0.3.0
>
>
> Need to add Kamon traces/metrics to omega client.
> Need to find the major flows in omega client side and need to add the kamon
> annotations for traces/metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
