[
https://issues.apache.org/jira/browse/SCB-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701306#comment-16701306
] ASF GitHub Bot commented on SCB-1052: ------------------------------------- codecov-io commented on issue #501: SCB-1052 Import zap logger without binding go version URL: https://github.com/apache/servicecomb-service-center/pull/501#issuecomment-442292501 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=h1) Report > Merging [#501](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/7aceab7f2ccb804089627bfdb82e7d7a62ab259a?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #501 +/- ## ========================================== - Coverage 59.25% 59.21% -0.04% ========================================== Files 166 166 Lines 13880 13880 ========================================== - Hits 8224 8219 -5 - Misses 5074 5075 +1 - Partials 582 586 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/log/log\_zap.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dfemFwLmdv) | `100% <ø> (ø)` | | | [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `61.29% <0%> (-5.38%)` | :arrow_down: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/501/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <0%> (+2.63%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=footer). Last update [7aceab7...a0ed616](https://codecov.io/gh/apache/servicecomb-service-center/pull/501?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] > import zap logger without binding go version > -------------------------------------------- > > Key: SCB-1052 > URL: https://issues.apache.org/jira/browse/SCB-1052 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
