[
https://issues.apache.org/jira/browse/SCB-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701507#comment-16701507
]
ASF GitHub Bot commented on SCB-1052:
-------------------------------------
little-cui closed pull request #501: SCB-1052 Import zap logger without binding
go version
URL: https://github.com/apache/servicecomb-service-center/pull/501
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pkg/log/log.go b/pkg/log/log.go
index e2539de9..43d0cfa8 100644
--- a/pkg/log/log.go
+++ b/pkg/log/log.go
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-// +build !go1.9
+// +build nozap
package log
diff --git a/pkg/log/log_go19.go b/pkg/log/log_zap.go
similarity index 98%
rename from pkg/log/log_go19.go
rename to pkg/log/log_zap.go
index 101a419c..f0c6abf9 100644
--- a/pkg/log/log_go19.go
+++ b/pkg/log/log_zap.go
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-// +build go1.9
+// +build !nozap
package log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> import zap logger without binding go version
> --------------------------------------------
>
> Key: SCB-1052
> URL: https://issues.apache.org/jira/browse/SCB-1052
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.2.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
