[
https://issues.apache.org/jira/browse/SCB-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704163#comment-16704163
]
ASF GitHub Bot commented on SCB-1056:
-------------------------------------
liubao68 edited a comment on issue #1017: [SCB-1056] put provider flow control
logic in front
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1017#issuecomment-443069310
I don't think change the handler execution sequence is a good idea. I got
another solution for using handler logic alone. Here is an example :
https://github.com/huaweicse/cse-java-chassis-samples/blob/master/porter/gateway-service/src/main/java/com/huawei/cse/porter/gateway/UiDispatcher.java
I used LoadBalancer handler here to do loadbalance and isolation logic for web
page request dispatching
I suggest add a configuration, e.g. servicecomb.flowcontrol.transport.enable
to make flow controll logic executed before handler, and is a standalone logic,
and you can resuse the code of handler. And the execution will not influence
any handler logic(that's executed one by one, and if you configured flowcontrol
handler, it will also be executed, that's twice execution).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Put provider QPS flow control in front
> --------------------------------------
>
> Key: SCB-1056
> URL: https://issues.apache.org/jira/browse/SCB-1056
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Major
>
> Currently provider QPS flow control is in ProviderQpsFlowControlHandler which
> works in provider handler chain. As a result, the flow control logic takes
> effect too late and much CPU resource is wasted on processing those requests
> that should be rejected earlier.
> Put the provider QPS flow control logic in front can save the resource.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
