[
https://issues.apache.org/jira/browse/SCB-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705610#comment-16705610
]
ASF GitHub Bot commented on SCB-1056:
-------------------------------------
yhs0092 commented on issue #1017: [SCB-1056] put provider flow control logic in
front
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1017#issuecomment-443396967
I think a better solution is to refactor the handler mechanism and let the
handler execution position more flexiable. The PR just provides a temporary
solution.
And I don't use the `ProviderQpsFlowControlHandler` like `UiDispathcer`
using `LoadBalanceHandler`, because I want to avoid importing extra maven
dependency.
The better solution may require a full refactoring design for handler
mechanism. This should be tracked in a new issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Put provider QPS flow control in front
> --------------------------------------
>
> Key: SCB-1056
> URL: https://issues.apache.org/jira/browse/SCB-1056
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Major
>
> Currently provider QPS flow control is in ProviderQpsFlowControlHandler which
> works in provider handler chain. As a result, the flow control logic takes
> effect too late and much CPU resource is wasted on processing those requests
> that should be rejected earlier.
> Put the provider QPS flow control logic in front can save the resource.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
