[
https://issues.apache.org/jira/browse/SCB-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713675#comment-16713675
]
ASF GitHub Bot commented on SCB-1053:
-------------------------------------
codecov-io commented on issue #508: WIP: SCB-1053 Add instances request struct
URL:
https://github.com/apache/servicecomb-service-center/pull/508#issuecomment-445459421
#
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=h1)
Report
> Merging
[#508](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/fad2b5811f0476069fdfd68e65d14e7b2c81941a?src=pr&el=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 59.31% 59.35% +0.04%
==========================================
Files 166 166
Lines 13944 13944
==========================================
+ Hits 8271 8277 +6
+ Misses 5088 5081 -7
- Partials 585 586 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[server/service/util/domain\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==)
| `59.7% <0%> (-1.5%)` | :arrow_down: |
|
[scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==)
| `94.87% <0%> (-1.29%)` | :arrow_down: |
|
[server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv)
| `72.6% <0%> (-0.34%)` | :arrow_down: |
|
[server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv)
| `53.47% <0%> (+0.26%)` | :arrow_up: |
|
[server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==)
| `84.51% <0%> (+0.64%)` | :arrow_up: |
|
[server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv)
| `78.87% <0%> (+9.85%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=footer).
Last update
[fad2b58...12dc01f](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Batch microservices instances discovery API
> -------------------------------------------
>
> Key: SCB-1053
> URL: https://issues.apache.org/jira/browse/SCB-1053
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.2.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
