[
https://issues.apache.org/jira/browse/SCB-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716885#comment-16716885
] ASF GitHub Bot commented on SCB-1053: ------------------------------------- codecov-io edited a comment on issue #508: SCB-1053 Add instances request struct URL: https://github.com/apache/servicecomb-service-center/pull/508#issuecomment-445459421 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=h1) Report > Merging [#508](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/fad2b5811f0476069fdfd68e65d14e7b2c81941a?src=pr&el=desc) will **increase** coverage by `0.1%`. > The diff coverage is `67.68%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #508 +/- ## ========================================= + Coverage 59.31% 59.42% +0.1% ========================================= Files 166 166 Lines 13944 14050 +106 ========================================= + Hits 8271 8349 +78 - Misses 5088 5110 +22 - Partials 585 591 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `51.91% <100%> (ø)` | :arrow_up: | | [server/service/instance\_validator.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.2% <66.24%> (-0.05%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `59.7% <0%> (-1.5%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `94.87% <0%> (-1.29%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.36% <0%> (+0.18%)` | :arrow_up: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `78.87% <0%> (+9.85%)` | :arrow_up: | | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `90% <0%> (+10%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=footer). Last update [fad2b58...1b4bf1b](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] > Batch microservices instances discovery API > ------------------------------------------- > > Key: SCB-1053 > URL: https://issues.apache.org/jira/browse/SCB-1053 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
