[
https://issues.apache.org/jira/browse/SHINDIG-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058111#comment-13058111
]
[email protected] commented on SHINDIG-1554:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/983/#review938
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2011-06-30 14:51:09, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/983/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-30 14:51:09)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Change to return first descendant iframe element instead of just
firstChild.
bq.
bq.
bq. This addresses bug SHINDIG-1554.
bq. https://issues.apache.org/jira/browse/SHINDIG-1554
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/gadget_holder.js
1137018
bq.
bq. Diff: https://reviews.apache.org/r/983/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested in example container using a gadget with pubsub-2 feature.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> gadget_holder.getIframeElement fails to return the iframe element when
> pubsub-2 feature is in use
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1554
> URL: https://issues.apache.org/jira/browse/SHINDIG-1554
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2
> Reporter: Dan Dumont
> Attachments: myChanges.patch
>
>
> The iframe element is created 2 different ways depending on if you use
> pubsub-2(OpenAjaxHub) feature or not. The OAH code wraps the iframe element
> in a span to work around some IE problem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
