[
https://issues.apache.org/jira/browse/SHINDIG-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065239#comment-13065239
]
[email protected] commented on SHINDIG-1554:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/983/
-----------------------------------------------------------
(Updated 2011-07-14 13:13:32.377521)
Review request for shindig.
Changes
-------
Thanks for catching that, Stanton!
Summary
-------
Change to return first descendant iframe element instead of just firstChild.
This addresses bug SHINDIG-1554.
https://issues.apache.org/jira/browse/SHINDIG-1554
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1146678
Diff: https://reviews.apache.org/r/983/diff
Testing
-------
Tested in example container using a gadget with pubsub-2 feature.
Thanks,
Dan
> gadget_holder.getIframeElement fails to return the iframe element when
> pubsub-2 feature is in use
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1554
> URL: https://issues.apache.org/jira/browse/SHINDIG-1554
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2
> Reporter: Dan Dumont
> Attachments: gadget_holder.getIframeElement.patch
>
>
> The iframe element is created 2 different ways depending on if you use
> pubsub-2(OpenAjaxHub) feature or not. The OAH code wraps the iframe element
> in a span to work around some IE problem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
