[
https://issues.apache.org/jira/browse/SHINDIG-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084053#comment-13084053
]
[email protected] commented on SHINDIG-1568:
--------------------------------------------------------
bq. On 2011-08-12 00:37:02, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js,
line 223
bq. > <https://reviews.apache.org/r/1476/diff/2/?file=32304#file32304line223>
bq. >
bq. > Maybe I should have looked at this functionality earlier but I am
struggling to grasp this 'listener' functionality to get the preferences when
navigating to the gadget. Why wouldn't the container get the preferences
before they call navigate gadget and just stick them in renderParams when
calling navigateGadget?
I agree with Ryan's comment -- this doesn't seem like it should be necessary.
We actually use the approach Ryan is describing already in Rave and I can
confirm that it works just fine.
- Jesse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1476/#review1413
-----------------------------------------------------------
On 2011-08-11 23:35:43, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1476/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-11 23:35:43)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Spec Change:
http://code.google.com/p/opensocial-resources/issues/detail?id=1203
bq.
bq. Change the GET_PREFERENCES api to be asynchronous
bq.
bq.
bq. This addresses bug SHINDIG-1568.
bq. https://issues.apache.org/jira/browse/SHINDIG-1568
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1156829
bq.
bq. Diff: https://reviews.apache.org/r/1476/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Common Container GET_PREFERENCES api should be async
> ----------------------------------------------------
>
> Key: SHINDIG-1568
> URL: https://issues.apache.org/jira/browse/SHINDIG-1568
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Dan Dumont
> Priority: Minor
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
