[
https://issues.apache.org/jira/browse/SHINDIG-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084145#comment-13084145
]
[email protected] commented on SHINDIG-1568:
--------------------------------------------------------
bq. On 2011-08-12 00:37:02, Ryan Baxter wrote:
bq. >
bq.
bq. Dan Dumont wrote:
bq. The spec declared the 2 common container config params (set/get) to be
optional. It's not necessary to use them.
bq. However, since fetching preferences is such a common task for
containers it seemed nice to provide this optional convenience to containers.
bq.
bq. I did not want to make it mandatory, so you'll note that if you supply
the preferences in the renderParams, they will be used instead.
bq.
bq. Ryan Baxter wrote:
bq. Ok I can buy that, as long as its up to the container to decide what
it wants to do I am fine with providing both methods. Jesse, does this sound
OK to you?
Yes -- sounds good to me too. I didn't realize a formal spec had actually been
written around the common container, that's great to see. I knew there were
some discussions of it but I hadn't actually seen it yet. Now that I've read
over the spec a bit this makes more sense to me.
- Jesse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1476/#review1413
-----------------------------------------------------------
On 2011-08-11 23:35:43, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1476/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-11 23:35:43)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Spec Change:
http://code.google.com/p/opensocial-resources/issues/detail?id=1203
bq.
bq. Change the GET_PREFERENCES api to be asynchronous
bq.
bq.
bq. This addresses bug SHINDIG-1568.
bq. https://issues.apache.org/jira/browse/SHINDIG-1568
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1156829
bq.
bq. Diff: https://reviews.apache.org/r/1476/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Common Container GET_PREFERENCES api should be async
> ----------------------------------------------------
>
> Key: SHINDIG-1568
> URL: https://issues.apache.org/jira/browse/SHINDIG-1568
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Dan Dumont
> Priority: Minor
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
