[
https://issues.apache.org/jira/browse/SHINDIG-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089894#comment-13089894
] [email protected] commented on SHINDIG-1591: -------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1615/#review1604 ----------------------------------------------------------- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js <https://reviews.apache.org/r/1615/#comment3626> How does this ever get called? Shouldn't this be called when the gadget calles removeListener? If so it should be called from your router function...right? http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js <https://reviews.apache.org/r/1615/#comment3627> Shouldn't there be a test for removeListener as well? - Ryan On 2011-08-23 23:06:15, Matthew Hatem wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1615/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-08-23 23:06:15) bq. bq. bq. Review request for shindig and Ryan Baxter. bq. bq. bq. Summary bq. ------- bq. bq. https://issues.apache.org/jira/browse/SHINDIG-1591 bq. bq. bq. This addresses bug SHINDIG-1591. bq. https://issues.apache.org/jira/browse/SHINDIG-1591 bq. bq. bq. Diffs bq. ----- bq. bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml 1160436 bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1160436 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml 1160436 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1160436 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1160436 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/taming.js 1160436 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1160436 bq. bq. Diff: https://reviews.apache.org/r/1615/diff bq. bq. bq. Testing bq. ------- bq. bq. Passes all unit tests. bq. bq. bq. Thanks, bq. bq. Matthew bq. bq. > Selection implementation does not match spec > -------------------------------------------- > > Key: SHINDIG-1591 > URL: https://issues.apache.org/jira/browse/SHINDIG-1591 > Project: Shindig > Issue Type: Bug > Components: Javascript > Affects Versions: 3.0.0 > Reporter: Matthew Hatem > > The selection feature does not match the spec (addListenter vs. > addSelectionListener) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
