[
https://issues.apache.org/jira/browse/SHINDIG-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089911#comment-13089911
]
[email protected] commented on SHINDIG-1591:
--------------------------------------------------------
bq. On 2011-08-24 00:22:17, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js,
line 96
bq. > <https://reviews.apache.org/r/1615/diff/1/?file=34109#file34109line96>
bq. >
bq. > How does this ever get called? Shouldn't this be called when the
gadget calles removeListener? If so it should be called from your router
function...right?
bq.
bq. Matthew Hatem wrote:
bq. This allows the container to add and remove listeners, has nothing to
do with gadget level API.
bq.
bq. Ryan Baxter wrote:
bq. So when the gadget adds a listener we add it to a list in the
container, but when a gadget removes a listener we never remove it from the
list in the container....why?
We've talked about this before. Each gadget adds only one listener (lazily) to
the list in the container which proxies events to (potentially many) listeners
registered with a local list at the gadget. This cuts down on the number of
RPCs that are necessary to notify everyone.
You might argue that I need a lifecycle listener to cleanup the proxy
listeners. I don't want to hold up this patch for that though, I'll open a
separate issue for that.
bq. On 2011-08-24 00:22:17, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js,
line 84
bq. > <https://reviews.apache.org/r/1615/diff/1/?file=34111#file34111line84>
bq. >
bq. > Shouldn't there be a test for removeListener as well?
bq.
bq. Matthew Hatem wrote:
bq. Yes I will add one.
I take that back. It's currently not possible to test this without exposing
things that should be private.
Is there plan to upgrade/improve the unit testing in Shinding?
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1615/#review1604
-----------------------------------------------------------
On 2011-08-23 23:06:15, Matthew Hatem wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1615/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-23 23:06:15)
bq.
bq.
bq. Review request for shindig and Ryan Baxter.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/SHINDIG-1591
bq.
bq.
bq. This addresses bug SHINDIG-1591.
bq. https://issues.apache.org/jira/browse/SHINDIG-1591
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml
1160436
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml
1160436
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml
1160436
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
1160436
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js
1160436
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/taming.js
1160436
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js
1160436
bq.
bq. Diff: https://reviews.apache.org/r/1615/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passes all unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Matthew
bq.
bq.
> Selection implementation does not match spec
> --------------------------------------------
>
> Key: SHINDIG-1591
> URL: https://issues.apache.org/jira/browse/SHINDIG-1591
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Hatem
>
> The selection feature does not match the spec (addListenter vs.
> addSelectionListener)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
