[
https://issues.apache.org/jira/browse/SHINDIG-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090631#comment-13090631
]
[email protected] commented on SHINDIG-1594:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1635/#review1622
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
<https://reviews.apache.org/r/1635/#comment3652>
I dont think you need this else
- Ryan
On 2011-08-24 17:56:11, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1635/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-24 17:56:11)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I ran into an issue loading the container across domains with the recent
change. This should fix it.
bq.
bq.
bq. This addresses bug SHINDIG-1594.
bq. https://issues.apache.org/jira/browse/SHINDIG-1594
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
1160787
bq.
bq. Diff: https://reviews.apache.org/r/1635/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Cross domain RPC calls failing
> ------------------------------
>
> Key: SHINDIG-1594
> URL: https://issues.apache.org/jira/browse/SHINDIG-1594
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
>
> Because of some recent changes in callSameDomain, cross domain RPC calls are
> failing. The RPC code calls callSameDomain even for cross domain calls
> expecting it to return false, however with some recent changes we can get
> into a state where the second time we call callSameDomain for the same gadget
> it will not fail and we try to call functions across different domains, which
> is not allowed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
