[
https://issues.apache.org/jira/browse/SHINDIG-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091334#comment-13091334
]
[email protected] commented on SHINDIG-1594:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1635/
-----------------------------------------------------------
(Updated 2011-08-25 21:16:54.056132)
Review request for shindig, johnfargo and Ryan Baxter.
Summary (updated)
-------
I ran into an issue loading the container across domains with the recent
change. This should fix it.
I'd like to add that this code could be drastically simplified if this were
fixed:
https://bugs.webkit.org/show_bug.cgi?id=43504 ( has 2 bugs linked in the
description for the areas that need fixing ).
Currently in webkit, cross-origin errors are not throwing catch-able errors and
pollute the console quite considerably in chrome and safari.
I don't suppose anyone knows any webkit committers who could update and push
this patch? From the comments it looks like the community has come around in
support of the change, but the original author of the patch doesn't have the
time anymore to pursue it.
This addresses bug SHINDIG-1594.
https://issues.apache.org/jira/browse/SHINDIG-1594
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
1160787
Diff: https://reviews.apache.org/r/1635/diff
Testing
-------
Thanks,
Dan
> Cross domain RPC calls failing
> ------------------------------
>
> Key: SHINDIG-1594
> URL: https://issues.apache.org/jira/browse/SHINDIG-1594
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
>
> Because of some recent changes in callSameDomain, cross domain RPC calls are
> failing. The RPC code calls callSameDomain even for cross domain calls
> expecting it to return false, however with some recent changes we can get
> into a state where the second time we call callSameDomain for the same gadget
> it will not fail and we try to call functions across different domains, which
> is not allowed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira