[
https://issues.apache.org/jira/browse/SHINDIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091983#comment-13091983
]
[email protected] commented on SHINDIG-1596:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/
-----------------------------------------------------------
(Updated 2011-08-26 19:48:19.931881)
Review request for shindig and Ryan Baxter.
Changes
-------
Adding some better documentation and updated the workflow so that we also set
the view to the alias we used. This is important so that the gadget holder's
getView API returns the correct thing.
Summary
-------
osapi.container.GadgetSite.prototype.render fails to render a gadget using a
given view when that gadget does not explicitly define that view, even in the
case where the container configuration has aliases for that view.
For instance, Gadget A supports the "profile" and "canvas" views only. The
container configuration defines the "home" view and provides "profile" as an
alias for "home". In the use case where the container tries to render Gadget A
using the "home" view, gadget render will fail, even though the gadget supports
"profile" and it has been specified as an alias for "home" in the container
configuration.
This problem commonly manifests itself in Shindig because of the way "default"
views are handled. By default, Shindig will attempt to render the gadget using
the "default" view. If the gadget does not support that view, rendering will
fail.
This addresses bug SHINDIG-1596.
https://issues.apache.org/jira/browse/SHINDIG-1596
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1160327
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1160327
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java
1160327
Diff: https://reviews.apache.org/r/1657/diff
Testing
-------
Tested rendering a gadget in the "default" view case where the gadget doesn't
support default.
Thanks,
Stanton
> Common Container does not utilize view aliases when rendering a gadget
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1596
> URL: https://issues.apache.org/jira/browse/SHINDIG-1596
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Fix For: 3.0.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> osapi.container.GadgetSite.prototype.render fails to render a gadget using a
> given view when that gadget does not explicitly define that view, even in the
> case where the container configuration has aliases for that view.
> For instance, Gadget A supports the "profile" and "canvas" views only. The
> container configuration defines the "home" view and provides "profile" as an
> alias for "home". In the use case where the container tries to render Gadget
> A using the "home" view, gadget render will fail, even though the gadget
> supports "profile" and it has been specified as an alias for "home" in the
> container configuration.
> This problem commonly manifests itself in Shindig because of the way
> "default" views are handled. By default, Shindig will attempt to render the
> gadget using the "default" view. If the gadget does not support that view,
> rendering will fail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
