[
https://issues.apache.org/jira/browse/SHINDIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093000#comment-13093000
]
[email protected] commented on SHINDIG-1596:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1657/#review1680
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
<https://reviews.apache.org/r/1657/#comment3833>
Could you refactor this code and the code below into one function since its
the same?
- Ryan
On 2011-08-26 19:48:19, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1657/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-26 19:48:19)
bq.
bq.
bq. Review request for shindig and Ryan Baxter.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. osapi.container.GadgetSite.prototype.render fails to render a gadget using
a given view when that gadget does not explicitly define that view, even in the
case where the container configuration has aliases for that view.
bq.
bq. For instance, Gadget A supports the "profile" and "canvas" views only. The
container configuration defines the "home" view and provides "profile" as an
alias for "home". In the use case where the container tries to render Gadget A
using the "home" view, gadget render will fail, even though the gadget supports
"profile" and it has been specified as an alias for "home" in the container
configuration.
bq.
bq. This problem commonly manifests itself in Shindig because of the way
"default" views are handled. By default, Shindig will attempt to render the
gadget using the "default" view. If the gadget does not support that view,
rendering will fail.
bq.
bq.
bq. This addresses bug SHINDIG-1596.
bq. https://issues.apache.org/jira/browse/SHINDIG-1596
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
1160327
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1160327
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1160327
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java
1160327
bq.
bq. Diff: https://reviews.apache.org/r/1657/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested rendering a gadget in the "default" view case where the gadget
doesn't support default.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Common Container does not utilize view aliases when rendering a gadget
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1596
> URL: https://issues.apache.org/jira/browse/SHINDIG-1596
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Fix For: 3.0.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> osapi.container.GadgetSite.prototype.render fails to render a gadget using a
> given view when that gadget does not explicitly define that view, even in the
> case where the container configuration has aliases for that view.
> For instance, Gadget A supports the "profile" and "canvas" views only. The
> container configuration defines the "home" view and provides "profile" as an
> alias for "home". In the use case where the container tries to render Gadget
> A using the "home" view, gadget render will fail, even though the gadget
> supports "profile" and it has been specified as an alias for "home" in the
> container configuration.
> This problem commonly manifests itself in Shindig because of the way
> "default" views are handled. By default, Shindig will attempt to render the
> gadget using the "default" view. If the gadget does not support that view,
> rendering will fail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
