[
https://issues.apache.org/jira/browse/SHINDIG-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093260#comment-13093260
]
li xu commented on SHINDIG-1604:
--------------------------------
Regarding this comment:
Currently the code inject BasicAuthorityProvider to allow Shindig Java to be
deploy in non root environment.
However this is not necessary since the BasicAuthority is bind to Authority in
DefaultGuiceModule
Why it still bind to BasicAuthorityProvider?
thanks,
li
> Inject Authority object instead of injecting the BasicAuthorityProvider itself
> ------------------------------------------------------------------------------
>
> Key: SHINDIG-1604
> URL: https://issues.apache.org/jira/browse/SHINDIG-1604
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Attachments: SHINDIG-1604.patch
>
>
> Currently the code inject BasicAuthorityProvider to allow Shindig Java to be
> deploy in non root environment.
> However this is not necessary since the BasicAuthority is bind to Authority
> in DefaultGuiceModule:
> bind(Authority.class).toProvider(BasicAuthorityProvider.class);
> we just need to inject Authority instance itself because we dont really need
> multiple instances of Authority which is the main purpose of the Provider
> injection.
> Implementation of Authority such as BasicAuthority has to be immutable and
> thread safe.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
