[
https://issues.apache.org/jira/browse/SHINDIG-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093296#comment-13093296
]
[email protected] commented on SHINDIG-1604:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1676/
-----------------------------------------------------------
(Updated 2011-08-29 23:14:02.691139)
Review request for shindig and li xu.
Changes
-------
Remove BasicAuthorityProvider and bind Authority directly to BasicAuthority
class. The BasicAuthority is not a big class and should not need separate
provider for it.
Summary
-------
Currently the code inject BasicAuthorityProvider to allow Shindig Java to be
deploy in non root environment.
However this is not necessary since the BasicAuthority is bind to Authority in
DefaultGuiceModule:
bind(Authority.class).toProvider(BasicAuthorityProvider.class);
we just need to inject Authority instance itself because we dont really need
multiple instances of Authority which is the main purpose of the Provider
injection.
Implementation of Authority such as BasicAuthority has to be immutable and
thread safe.
This addresses bug SHINDIG-1604.
https://issues.apache.org/jira/browse/SHINDIG-1604
Diffs (updated)
-----
trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java
1162967
trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java
1162967
trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java
1162967
trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityTest.java
PRE-CREATION
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
1162967
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
1162967
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthModule.java
1162967
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
1162967
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java
1162967
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
1162967
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java
1162967
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java
1162967
trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
1162967
Diff: https://reviews.apache.org/r/1676/diff
Testing
-------
Updated the JUnit test case to reflect the change
Thanks,
Henry
> Inject Authority object instead of injecting the BasicAuthorityProvider itself
> ------------------------------------------------------------------------------
>
> Key: SHINDIG-1604
> URL: https://issues.apache.org/jira/browse/SHINDIG-1604
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Attachments: SHINDIG-1604-v2.patch, SHINDIG-1604.patch
>
>
> Currently the code inject BasicAuthorityProvider to allow Shindig Java to be
> deploy in non root environment.
> However this is not necessary since the BasicAuthority is bind to Authority
> in DefaultGuiceModule:
> bind(Authority.class).toProvider(BasicAuthorityProvider.class);
> we just need to inject Authority instance itself because we dont really need
> multiple instances of Authority which is the main purpose of the Provider
> injection.
> Implementation of Authority such as BasicAuthority has to be immutable and
> thread safe.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
