[
https://issues.apache.org/jira/browse/SHINDIG-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093804#comment-13093804
]
[email protected] commented on SHINDIG-1607:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1682/#review1691
-----------------------------------------------------------
Overall this looks good. A few nits.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
<https://reviews.apache.org/r/1682/#comment3848>
Should be Array of GadgetSites at the return type
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
<https://reviews.apache.org/r/1682/#comment3849>
Can site.getActiveGadgetHolder() ever return null? If so we should guard
against it here.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
<https://reviews.apache.org/r/1682/#comment3850>
Again, can getActiveGadgetHolder() ever return null?
- Stanton
On 2011-08-30 14:32:21, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1682/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-30 14:32:21)
bq.
bq.
bq. Review request for Ryan Baxter, Matthew Hatem and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. It looks like the current impl of declarative actions pick the first
gadget site where the URL matches and fires the action in that. The actions
spec lets you specify a target view, so we should make sure to check if the
site has that view rendered. It may also be rendered more than once, so we
should fire the action in all of them.
bq.
bq.
bq. This addresses bug SHINDIG-1607.
bq. https://issues.apache.org/jira/browse/SHINDIG-1607
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1161182
bq.
bq. Diff: https://reviews.apache.org/r/1682/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Declared actions get fired in the first instance of the gadget, ignoring any
> specified view target in the declaration
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1607
> URL: https://issues.apache.org/jira/browse/SHINDIG-1607
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Dan Dumont
>
> It looks like the current impl of declarative actions pick the first gadget
> site where the URL matches and fires the action in that. The actions spec
> lets you specify a target view, so we should make sure to check if the site
> has that view rendered. It may also be rendered more than once, so we
> should fire the action in all of them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
