[
https://issues.apache.org/jira/browse/SHINDIG-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095269#comment-13095269
]
[email protected] commented on SHINDIG-1607:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1682/
-----------------------------------------------------------
(Updated 2011-09-01 12:47:32.468086)
Review request for shindig, Ryan Baxter, Matthew Hatem, and Stanton Sievers.
Changes
-------
Updated diff with fix for undefined check.
Summary
-------
It looks like the current impl of declarative actions pick the first gadget
site where the URL matches and fires the action in that. The actions spec lets
you specify a target view, so we should make sure to check if the site has that
view rendered. It may also be rendered more than once, so we should fire the
action in all of them.
This addresses bug SHINDIG-1607.
https://issues.apache.org/jira/browse/SHINDIG-1607
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1163664
Diff: https://reviews.apache.org/r/1682/diff
Testing
-------
Thanks,
Dan
> Declared actions get fired in the first instance of the gadget, ignoring any
> specified view target in the declaration
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1607
> URL: https://issues.apache.org/jira/browse/SHINDIG-1607
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Dan Dumont
>
> It looks like the current impl of declarative actions pick the first gadget
> site where the URL matches and fires the action in that. The actions spec
> lets you specify a target view, so we should make sure to check if the site
> has that view rendered. It may also be rendered more than once, so we
> should fire the action in all of them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
