[
https://issues.apache.org/jira/browse/SHINDIG-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094945#comment-13094945
]
[email protected] commented on SHINDIG-1612:
--------------------------------------------------------
bq. On 2011-08-31 21:30:42, Stanton Sievers wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js,
line 785
bq. > <https://reviews.apache.org/r/1689/diff/2/?file=37008#file37008line785>
bq. >
bq. > Can you also verify typeof callback is a Function? If I push a
non-Function into your actionListenerMap, it'll just get called in the
runAction code and puke.
bq.
bq. Dan Dumont wrote:
bq. To some degree, that kind of error might be useful for a container
author. It's not like random gadgets will be able to call this, it'a container
only method.
I do suppose I can have the code puke earlier in the initial register call so
that the error isn't deferred. Which is actually the point you were probably
trying to make.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1689/#review1706
-----------------------------------------------------------
On 2011-08-31 20:07:34, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1689/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-31 20:07:34)
bq.
bq.
bq. Review request for shindig, Ryan Baxter and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Specification:
http://code.google.com/p/opensocial-resources/issues/detail?id=1210
bq.
bq. Add 2 functions to the actions feature.
bq. 1 to allow the container to register a listener for an action being run.
The listener would be run whenever an action matching the id provided was run.
bq. 1 to allow the container to unregister(remove) any listener added with the
previous function.
bq.
bq.
bq. This addresses bug SHINDIG-1612.
bq. https://issues.apache.org/jira/browse/SHINDIG-1612
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1163664
bq.
bq. Diff: https://reviews.apache.org/r/1689/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. If anyone has any suggestions as to how to approach adding unit tests for
this, I'm all ears.
bq.
bq. It looks like that in order to get the actions api to hit this code, by
calling runAction, I'd need to somehow fake setting up a gadget site and
register a fake action.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Implement Specification: Issue 1210: Extend actions feature to allow
> container to register listeners for when actions are run
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1612
> URL: https://issues.apache.org/jira/browse/SHINDIG-1612
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Reporter: Dan Dumont
> Priority: Minor
> Attachments: upstream.patch
>
>
> Specification:
> http://code.google.com/p/opensocial-resources/issues/detail?id=1210
> Add 2 functions to the actions feature.
> 1 to allow the container to register a listener for an action being run. The
> listener would be run whenever an action matching the id provided was run.
> 1 to allow the container to unregister(remove) any listener added with the
> previous function.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
