[
https://issues.apache.org/jira/browse/SHINDIG-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106788#comment-13106788
]
[email protected] commented on SHINDIG-1612:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1689/
-----------------------------------------------------------
(Updated 2011-09-16 20:36:03.558948)
Review request for shindig, Ryan Baxter, Matthew Hatem, and Stanton Sievers.
Changes
-------
Added some nifty jsdoc annotations for closure compiler and better
clarification for some types.
Changed impl based on patch from Matt Hatem.
One noteworthy change is that the caller of addListener is expected to keep a
reference to the exact function passed into addListener in order to pass it in
to removeListener later. Remove tokens are no longer provided.
Summary
-------
Specification:
http://code.google.com/p/opensocial-resources/issues/detail?id=1210
Add 2 functions to the actions feature.
1 to allow the container to register a listener for an action being run. The
listener would be run whenever an action matching the id provided was run.
1 to allow the container to unregister(remove) any listener added with the
previous function.
This addresses bug SHINDIG-1612.
https://issues.apache.org/jira/browse/SHINDIG-1612
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1171739
Diff: https://reviews.apache.org/r/1689/diff
Testing
-------
If anyone has any suggestions as to how to approach adding unit tests for this,
I'm all ears.
It looks like that in order to get the actions api to hit this code, by calling
runAction, I'd need to somehow fake setting up a gadget site and register a
fake action.
Thanks,
Dan
> Implement Specification: Issue 1210: Extend actions feature to allow
> container to register listeners for when actions are run
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1612
> URL: https://issues.apache.org/jira/browse/SHINDIG-1612
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Reporter: Dan Dumont
> Priority: Minor
> Attachments: upstream.patch
>
>
> Specification:
> http://code.google.com/p/opensocial-resources/issues/detail?id=1210
> Add 2 functions to the actions feature.
> 1 to allow the container to register a listener for an action being run. The
> listener would be run whenever an action matching the id provided was run.
> 1 to allow the container to unregister(remove) any listener added with the
> previous function.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
