[ 
https://issues.apache.org/jira/browse/SHINDIG-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098188#comment-13098188
 ] 

[email protected] commented on SHINDIG-1614:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1729/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

Fixes use of undefined variable in dynamic width feature.

This error starts showing up when you use the feature and your gadget declares 
version 2.0 of the spec, which by default causes the doctype to be html5.
Without the declaration, documents would render in quirks mode, which would 
cause the width calculations to take a different code path.


This addresses bug SHINDIG-1614.
    https://issues.apache.org/jira/browse/SHINDIG-1614


Diffs
-----

  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js
 1165734 

Diff: https://reviews.apache.org/r/1729/diff


Testing
-------


Thanks,

Dan



> vw is undefined in dynamic-width feature
> ----------------------------------------
>
>                 Key: SHINDIG-1614
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1614
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>            Reporter: Dan Dumont
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to