[
https://issues.apache.org/jira/browse/SHINDIG-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098282#comment-13098282
]
[email protected] commented on SHINDIG-1614:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1729/#review1771
-----------------------------------------------------------
Ship it!
LGTM
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js
<https://reviews.apache.org/r/1729/#comment4050>
Optional: remove trailing space.
- Paul
On 2011-09-06 17:33:32, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1729/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-06 17:33:32)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fixes use of undefined variable in dynamic width feature.
bq.
bq. This error starts showing up when you use the feature and your gadget
declares version 2.0 of the spec, which by default causes the doctype to be
html5.
bq. Without the declaration, documents would render in quirks mode, which
would cause the width calculations to take a different code path.
bq.
bq.
bq. This addresses bug SHINDIG-1614.
bq. https://issues.apache.org/jira/browse/SHINDIG-1614
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js
1165734
bq.
bq. Diff: https://reviews.apache.org/r/1729/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> vw is undefined in dynamic-width feature
> ----------------------------------------
>
> Key: SHINDIG-1614
> URL: https://issues.apache.org/jira/browse/SHINDIG-1614
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Dan Dumont
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
