[
https://issues.apache.org/jira/browse/SHINDIG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119346#comment-13119346
]
[email protected] commented on SHINDIG-1634:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2149/
-----------------------------------------------------------
Review request for shindig, Henry Saputra and Dan Dumont.
Summary
-------
GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending
on the order the RPC service IDs returned in the JSON array. The code in
GadgetsHandlerService returns the IDs in a set which does note guarantee order,
so the order of the IDs in the JSON array may be different.
This addresses bug SHINDIG-1634.
https://issues.apache.org/jira/browse/SHINDIG-1634
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
1178236
Diff: https://reviews.apache.org/r/2149/diff
Testing
-------
Ran mvn build
Thanks,
Ryan
> Potential test failure in GadgetHandlerTest
> -------------------------------------------
>
> Key: SHINDIG-1634
> URL: https://issues.apache.org/jira/browse/SHINDIG-1634
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Attachments: issue-1634.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending
> on the order the RPC service IDs returned in the JSON array. The code in
> GadgetsHandlerService returns the IDs in a set which does note guarantee
> order, so the order of the IDs in the JSON array may be different.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
