[
https://issues.apache.org/jira/browse/SHINDIG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119378#comment-13119378
]
[email protected] commented on SHINDIG-1634:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2149/#review2264
-----------------------------------------------------------
Ship it!
For the future: since you're a committer and have CLA on file I'd just go ahead
and submit non-feature related fixes like this directly. Less time clicking in
jira == more time coding :)
- Paul
On 2011-10-03 15:01:39, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2149/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-03 15:01:39)
bq.
bq.
bq. Review request for shindig, Henry Saputra and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail
depending on the order the RPC service IDs returned in the JSON array. The code
in GadgetsHandlerService returns the IDs in a set which does note guarantee
order, so the order of the IDs in the JSON array may be different.
bq.
bq.
bq. This addresses bug SHINDIG-1634.
bq. https://issues.apache.org/jira/browse/SHINDIG-1634
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
1178236
bq.
bq. Diff: https://reviews.apache.org/r/2149/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran mvn build
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Potential test failure in GadgetHandlerTest
> -------------------------------------------
>
> Key: SHINDIG-1634
> URL: https://issues.apache.org/jira/browse/SHINDIG-1634
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Attachments: issue-1634.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending
> on the order the RPC service IDs returned in the JSON array. The code in
> GadgetsHandlerService returns the IDs in a set which does note guarantee
> order, so the order of the IDs in the JSON array may be different.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
