[
https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125335#comment-13125335
]
[email protected] commented on SHINDIG-1637:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/#review2517
-----------------------------------------------------------
FYI:
In eclipse, Ctrl+F
Find: [ \t]+$
Replace with:
Check off "Regular expressions" and then press "Replace All" :)
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
<https://reviews.apache.org/r/2333/#comment5681>
White space, and 2 below
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
<https://reviews.apache.org/r/2333/#comment5682>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
<https://reviews.apache.org/r/2333/#comment5683>
As we talked about offline, could you remove this method from the interface
and abstract implementation? And make this method in this class private? It
seems to be a private impl detail that doesn't need to be exposed.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5685>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5684>
Would this be an Impl if it's an abstract class? It's more of a partial
impl...
Is there already a practice in Shindig to postfix abstract classes with
"Impl" if they attempt to implement parts of an interface? (just curious)
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5686>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5687>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5688>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5689>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5690>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5691>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5692>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5693>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5694>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5695>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5696>
White space
- Dan
On 2011-10-10 20:23:15, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2333/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-10 20:23:15)
bq.
bq.
bq. Review request for Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The proposed changes are to introduce an abstract class that implements
LockedDomainService and provides some infrastructure to make creating one's own
LockedDomainService a bit easier.
bq.
bq. Sorry for the horrible diffs. I moved a lot of stuff around in
HashLockedDomainService.
bq.
bq.
bq. This addresses bug SHINDIG-1637.
bq. https://issues.apache.org/jira/browse/SHINDIG-1637
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
1181021
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java
1181021
bq.
bq. Diff: https://reviews.apache.org/r/2333/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated and ran existing JUnits.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Introduce abstract LockedDomainService implementation to enable easier
> customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has
> to implement all of the functionality from scratch. The proposed changes are
> to introduce an abstract class that implements LockedDomainService and
> provides some infrastructure to make creating one's own LockedDomainService a
> bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
